Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Min size and tolerance too small when using --maxzoom option #262

Closed
msbarry opened this issue Jun 7, 2022 · 2 comments
Closed

[BUG] Min size and tolerance too small when using --maxzoom option #262

msbarry opened this issue Jun 7, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@msbarry
Copy link
Contributor

msbarry commented Jun 7, 2022

Planetiler sets a tighter min size and tolerance at max zoom threshold to support overzooming, but it should instead let you change maxzoom without affecting the tiles that get emitted at each zoom.

image

https://osmus.slack.com/archives/C031V9E9RMG/p1654542711621759

@msbarry msbarry added the bug Something isn't working label Jun 7, 2022
@farfromrefug
Copy link
Contributor

We can see this as the need for 2 kind of maxzoom:

  • maxzoom related to maxzoom for simplification
  • maxzoom like the maximum zoom to render

I see 2 ways to fix this:

  • replace config.maxzoom() in FeatureCollector with MAX_ZOOM static variable which is now fixed to 14
  • create a second maxzoom configuration property. Maybe maxRenderZoom(or something) . In this case i dont know if we really need minRenderZoom or if config.minzoom() is used only for this.

The issue i see with the first one is the same issue as with MAX_ZOOM being hardcoded (related to #128). What if you want a different value than 14?

@msbarry
Copy link
Contributor Author

msbarry commented Jul 10, 2022

Fixed by #272

@msbarry msbarry closed this as completed Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants