Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model inference for connector classifier on queries #2137

Merged
merged 22 commits into from
Sep 8, 2024
Merged

Model inference for connector classifier on queries #2137

merged 22 commits into from
Sep 8, 2024
+314 −9

Conversation

ghost
Copy link

@ghost ghost commented Aug 14, 2024 •
edited by ghost
Loading

Description

The integrates the connector classifier model in the search preprocessing pipeline. Instead of using a LLM for auto detecting the sources, we use our own model instead if FEATURE_FLAG_USE_CONNECTOR_CLASSIFIER is set in the environment.

The model is warmed up by the API if the feature flag is set.

How Has This Been Tested?

Hard coded auto_detect_source_filter and tested search queries in Danswer's UI.

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024

@shukant-danswer is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

@ghost ghost marked this pull request as ready for review August 14, 2024 20:50
yuhongsun96
yuhongsun96 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good, added some comments

backend/danswer/main.py Outdated Show resolved Hide resolved
backend/danswer/secondary_llm_flows/source_filter.py Outdated Show resolved Hide resolved
backend/shared_configs/configs.py Outdated Show resolved Hide resolved
backend/shared_configs/model_server_models.py Show resolved Hide resolved
backend/model_server/custom_models.py Outdated Show resolved Hide resolved
backend/model_server/danswer_torch_model.py Outdated Show resolved Hide resolved
backend/model_server/danswer_torch_model.py Show resolved Hide resolved
backend/model_server/main.py Outdated Show resolved Hide resolved
backend/model_server/danswer_torch_model.py Outdated Show resolved Hide resolved
backend/model_server/custom_models.py Show resolved Hide resolved
@ghost ghost changed the title Draft: Model inference for connector classifier on queries Model inference for connector classifier on queries Aug 15, 2024
@yuhongsun96 yuhongsun96 disabled auto-merge September 8, 2024 21:43
@yuhongsun96 yuhongsun96 merged commit 362156f into onyx-dot-app:main Sep 8, 2024
3 of 4 checks passed
@onimsha onimsha mentioned this pull request Sep 13, 2024
Merged
8 tasks
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
Model inference for connector classifier on queries (onyx-dot-app#2137)
5956a53
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
Model inference for connector classifier on queries (onyx-dot-app#2137)
eb04638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yuhongsun96