Integration tests #2256
Merged
Integration tests #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
set auth_type to basic and require_email_verification to false
hagen-danswer
commented
Sep 1, 2024
| @@ -67,23 +67,6 @@ | |||
| logger = setup_logger() | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
moved to another file
| raise HTTPException( | ||
| status_code=401, | ||
| detail="Credential does not exist or does not belong to user", | ||
| detail=error_msg, | ||
| ) |
There was a problem hiding this comment.
need to look into long term fix for bubbling up failed api calls
| @@ -157,11 +153,12 @@ def associate_credential_to_connector( | |||
| user: User | None = Depends(current_curator_or_admin_user), | |||
| db_session: Session = Depends(get_session), | |||
| ) -> StatusResponse[int]: | |||
There was a problem hiding this comment.
used a more robust existing function to check
| @@ -514,35 +514,6 @@ def _validate_connector_allowed(source: DocumentSource) -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| def _check_connector_permissions( | |||
There was a problem hiding this comment.
used a more robust existing function
| @@ -48,9 +48,12 @@ class ConnectorBase(BaseModel): | |||
|
|
|||
|
|
|||
| class ConnectorUpdateRequest(ConnectorBase): | |||
There was a problem hiding this comment.
should test this somehow maybe
| @@ -261,6 +259,10 @@ class ConnectorCredentialPairMetadata(BaseModel): | |||
| groups: list[int] = Field(default_factory=list) | |||
|
|
|||
|
|
|||
Weves
reviewed
Sep 1, 2024
backend/tests/integration/tests/permissions/test_cc_pair_permissions.py
Outdated
Show resolved
Hide resolved
Weves
approved these changes
Sep 1, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
Yes