Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused env variables #2299

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Remove unused env variables #2299

merged 1 commit into from
Sep 2, 2024

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Sep 2, 2024

Everything has been moved to the UI, these env variables just confuse people 😢

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 6:52pm

@@ -37,7 +36,7 @@ def __init__(
# Not used here but you probably want a model server that isn't completely open
api_key: str | None,
timeout: int,
endpoint: str | None = GEN_AI_API_ENDPOINT,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: this class is unused currently, so this is a noop

Copy link
Contributor

@hagen-danswer hagen-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

negative LoC Classic value detraction

Looks good!

@hagen-danswer hagen-danswer added this pull request to the merge queue Sep 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2024
@Weves Weves added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit 033ec0b Sep 2, 2024
7 checks passed
@Weves Weves deleted the remove-unused-env-variables branch October 18, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants