Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update auth for litellm proxy #2316

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Update auth for litellm proxy #2316

merged 9 commits into from
Sep 4, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Sep 3, 2024 •
edited
Loading

Description

Allows users to pass access token to litellm proxy set up

How Has This Been Tested?

  • Construct auth-enabled and non-auth-enabled LiteLLM proxy + test
  • Construct other providers after testing

New test coming soon in sibling PR to validate this entire flow in the future.

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 8:40pm

@pablonyx pablonyx changed the title Update for auth for litellm proxy Update auth for litellm proxy Sep 4, 2024
rkuo-danswer
rkuo-danswer approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@rkuo-danswer rkuo-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, some possible small cleanup in comments

web/src/app/admin/embeddings/pages/utils.ts Outdated Show resolved Hide resolved
web/src/app/admin/embeddings/modals/ProviderCreationModal.tsx Outdated Show resolved Hide resolved
@pablonyx pablonyx enabled auto-merge September 4, 2024 20:39
@pablonyx pablonyx added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 34ba318 Sep 4, 2024
7 checks passed
@laurb9 laurb9 mentioned this pull request Sep 6, 2024
Closed
@onimsha onimsha mentioned this pull request Sep 13, 2024
Merged
8 tasks
@pablonyx pablonyx deleted the litellm_password branch October 17, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkuo-danswer rkuo-danswer rkuo-danswer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablonyx @rkuo-danswer