Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Dev Experience #2347

Merged
merged 8 commits into from
Sep 10, 2024
Merged

Improve Dev Experience #2347

merged 8 commits into from
Sep 10, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Sep 6, 2024 •
edited
Loading

Description

Additional Standardization of

  • effects
  • Passing props

How Has This Been Tested?

  • LLM Creation
  • LLM Update
  • Provider Creation
  • Anything with isPublicGroupSelector
  • Connector Creation

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 5:14pm

@pablonyx pablonyx changed the title Improve Dev Experiecne Improve Dev Experience Sep 7, 2024
hagen-danswer
hagen-danswer approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@hagen-danswer hagen-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pablonyx pablonyx added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 9f6e8bd Sep 10, 2024
7 checks passed
@onimsha onimsha mentioned this pull request Sep 13, 2024
Merged
8 tasks
@hagen-danswer hagen-danswer deleted the dev_ux branch September 27, 2024 16:06
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@pablonyx
Improve Dev Experience (onyx-dot-app#2347)
664964b 
* clean interfaces + improve dex experience

* update formatting

* update ports

* ports

* remove some number of unnecessary lines

* remove unnecssary isPublicGroupSelector checks in all spots

* add comment

* update building
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@pablonyx
Improve Dev Experience (onyx-dot-app#2347)
7da7963 
* clean interfaces + improve dex experience

* update formatting

* update ports

* ports

* remove some number of unnecessary lines

* remove unnecssary isPublicGroupSelector checks in all spots

* add comment

* update building
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hagen-danswer hagen-danswer hagen-danswer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablonyx @hagen-danswer