Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More explicit credential creation flow #2363

Merged
merged 5 commits into from
Sep 8, 2024
Merged

More explicit credential creation flow #2363

merged 5 commits into from
Sep 8, 2024
+81 −73

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Sep 8, 2024

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

@vercel Vercel
Copy link

vercel bot commented Sep 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 6:59pm

@pablonyx pablonyx changed the title More expliti drive credential creation flow More explicit credential creation flow Sep 8, 2024
Weves
Weves reviewed Sep 8, 2024
View reviewed changes
Copy link
Contributor

@Weves Weves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like some checks are failing 🧐

backend/danswer/server/documents/models.py Outdated Show resolved Hide resolved
@pablonyx pablonyx enabled auto-merge September 8, 2024 18:59
@Weves Weves disabled auto-merge September 8, 2024 19:09
@Weves Weves merged commit 1555ac9 into main Sep 8, 2024
5 of 7 checks passed
@Weves Weves deleted the drive branch September 8, 2024 19:09
@onimsha onimsha mentioned this pull request Sep 13, 2024
Merged
8 tasks
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@pablonyx
More explicit credential creation flow (onyx-dot-app#2363)
d87268f 
* more explcit drive credential creation flow

* remove logs

* update naming

* fix user-contributed formatting

* fix (^) v2
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@pablonyx
More explicit credential creation flow (onyx-dot-app#2363)
402ad27 
* more explcit drive credential creation flow

* remove logs

* update naming

* fix user-contributed formatting

* fix (^) v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weves Weves Weves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablonyx @Weves