-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SSL parameter support for redis #2389
Merged
Merged
+42
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
reference original PR at #2383 |
8 tasks
Hi @rkuo-danswer , you might need to handle SSL config in the redis_pool as well. something like: from danswer.configs.app_configs import (
REDIS_HOST,
REDIS_PASSWORD,
REDIS_PORT,
REDIS_SSL,
REDIS_SSL_CA_CERTS,
REDIS_SSL_CERT_REQS
)
#...
def _init_pool(self) -> None:
ssl_options = {}
if REDIS_SSL:
ssl_options = {
'ssl': True,
'ssl_ca_certs': REDIS_SSL_CA_CERTS,
'ssl_cert_reqs': REDIS_SSL_CERT_REQS
}
# Create the connection pool with SSL support if needed
self._pool = redis.ConnectionPool(
host=REDIS_HOST,
port=REDIS_PORT,
db=0, # You may need to define the DB number if using non-default
password=REDIS_PASSWORD,
max_connections=REDIS_POOL_MAX_CONNECTIONS,
**ssl_options
) |
hagen-danswer
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
8 tasks
rajivml
pushed a commit
to UiPath/danswer
that referenced
this pull request
Oct 2, 2024
* add SSL parameter support for redis * add ssl support to redis pool
rajivml
pushed a commit
to UiPath/danswer
that referenced
this pull request
Oct 2, 2024
* add SSL parameter support for redis * add ssl support to redis pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes DAN-597.
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: