Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connector deletion failure message #2392

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Add connector deletion failure message #2392

merged 5 commits into from
Sep 12, 2024
+110 −8

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Sep 10, 2024 •
edited
Loading

Description

Screenshot 2024-09-10 at 3 20 25 PM

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 3:56pm

@pablonyx pablonyx changed the title Add deletion failure message Add connector deletion failure message Sep 10, 2024
rkuo-danswer
rkuo-danswer previously approved these changes Sep 11, 2024
View reviewed changes
@rkuo-danswer rkuo-danswer self-requested a review September 11, 2024 01:35
@rkuo-danswer rkuo-danswer dismissed their stale review September 11, 2024 01:35

mypy errors

@pablonyx pablonyx self-assigned this Sep 11, 2024
@pablonyx pablonyx added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@pablonyx pablonyx added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@Weves Weves added this pull request to the merge queue Sep 12, 2024
@Weves Weves removed this pull request from the merge queue due to a manual request Sep 12, 2024
@Weves Weves merged commit 58bdf9d into main Sep 12, 2024
7 checks passed
@Weves Weves deleted the deletion_error_display branch September 12, 2024 05:38
@onimsha onimsha mentioned this pull request Sep 13, 2024
Merged
8 tasks
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@pablonyx
Add connector deletion failure message (onyx-dot-app#2392)
3197fc1
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@pablonyx
Add connector deletion failure message (onyx-dot-app#2392)
f0bd02a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkuo-danswer rkuo-danswer rkuo-danswer approved these changes

Assignees

@pablonyx pablonyx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablonyx @rkuo-danswer @Weves