Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env variables for overriding embedding batch size #2395

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Add env variables for overriding embedding batch size #2395

merged 3 commits into from
Sep 12, 2024
+14 −3

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Sep 11, 2024 •
edited
Loading

Description

Allows users to override (separately) index embedding batch size and general embedding batch size

Fixes Dan-606

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 0:42am

@pablonyx pablonyx changed the title Add env variabels for overriding embedding size Add env variabels for overriding embedding batchh size Sep 11, 2024
@pablonyx pablonyx changed the title Add env variabels for overriding embedding batchh size Add env variables for overriding embedding batch size Sep 12, 2024
@pablonyx pablonyx enabled auto-merge September 12, 2024 00:40
@pablonyx pablonyx added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit aee5fcd Sep 12, 2024
7 checks passed
@onimsha onimsha mentioned this pull request Sep 13, 2024
Merged
8 tasks
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@pablonyx
Add env variables for overriding embedding batch size (onyx-dot-app#2395
e0a7134 
)

* add env variabels for overriding

* proper ports

* proper overrides
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@pablonyx
Add env variables for overriding embedding batch size (onyx-dot-app#2395
675b373 
)

* add env variabels for overriding

* proper ports

* proper overrides
@laurb9 laurb9 mentioned this pull request Oct 14, 2024
Closed
@pablonyx pablonyx deleted the env_embedding_size branch October 17, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkuo-danswer rkuo-danswer rkuo-danswer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablonyx @rkuo-danswer