Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warm up reranker on model switch #2408

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Sep 12, 2024

Description

Fixes Dan-453

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 9:29pm

@@ -180,6 +181,14 @@ def update_current_search_settings(
logger.warning("No current search settings found to update")
return

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo
"settings"

@hagen-danswer hagen-danswer added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@hagen-danswer hagen-danswer added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit cb2169f Sep 12, 2024
7 checks passed
@hagen-danswer hagen-danswer deleted the warmup_selection_encoders branch September 12, 2024 22:40
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
* warm up reranker on model switch

* properly type

* fix issue

* Update search_settings.py
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
* warm up reranker on model switch

* properly type

* fix issue

* Update search_settings.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants