Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(minor) add a tiny bit of clarity to index doc counts #2414

Merged
merged 1 commit into from
Sep 12, 2024
Merged

(minor) add a tiny bit of clarity to index doc counts #2414

merged 1 commit into from
Sep 12, 2024
+21 −2

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Sep 12, 2024 •
edited
Loading

Description

Screenshot 2024-09-12 at 10 03 51 AM

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 5:03pm

hagen6835
hagen6835 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@hagen6835 hagen6835 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

hagen6835
hagen6835 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@hagen6835 hagen6835 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval

hagen-danswer
hagen-danswer approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@hagen-danswer hagen-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fr

@pablonyx pablonyx added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@hagen-danswer hagen-danswer added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@hagen-danswer hagen-danswer added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@hagen-danswer hagen-danswer added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 79aa5dd Sep 12, 2024
7 checks passed
@hagen-danswer hagen-danswer deleted the clarity_indexing_numbers branch September 12, 2024 22:12
@onimsha onimsha mentioned this pull request Sep 13, 2024
Merged
8 tasks
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@pablonyx
add a tiny bit of clarity to index doc counts (onyx-dot-app#2414)
393164a
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@pablonyx
add a tiny bit of clarity to index doc counts (onyx-dot-app#2414)
774f678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hagen-danswer hagen-danswer hagen-danswer approved these changes

@hagen6835 hagen6835 hagen6835 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablonyx @hagen6835 @hagen-danswer