simple apis now cited/context doc indices #2419
Merged
+134
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hagen-danswer
commented
Sep 12, 2024
| @@ -60,7 +60,11 @@ def model_dump(self, *args: list, **kwargs: dict[str, Any]) -> dict[str, Any]: | |||
|
|
|||
|
|
|||
| class LLMRelevanceFilterResponse(BaseModel): | |||
| relevant_chunk_indices: list[int] | |||
| llm_selected_doc_indices: list[int] | |||
There was a problem hiding this comment.
renamed this everywhere
| @@ -1,9 +1,28 @@ | |||
| import json | |||
| from datetime import datetime | |||
| from typing import Any | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
made this function able to encode datetime objects
| elif isinstance(packet, StreamingError): | ||
| response.error_msg = packet.error | ||
| elif isinstance(packet, ChatMessageDetail): | ||
| response.message_id = packet.message_id | ||
| elif isinstance(packet, FinalUsedContextDocsResponse): |
There was a problem hiding this comment.
here we get the final context docs and get the int index of that doc in the list of docs we are already returning
| @@ -74,4 +74,6 @@ class ChatBasicResponse(BaseModel): | |||
| simple_search_docs: list[SimpleDoc] | None = None | |||
| error_msg: str | None = None | |||
| message_id: int | None = None | |||
There was a problem hiding this comment.
these are the 2 new fields (and one renamed) that we are returning through the simple apis
| @@ -525,8 +523,9 @@ def _process_stream( | |||
| SearchResponseSummary, message.response | |||
| ).top_sections | |||
| ] | |||
There was a problem hiding this comment.
here we yield the final context docs
pablonyx
approved these changes
Sep 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
8 tasks
rajivml
pushed a commit
to UiPath/danswer
that referenced
this pull request
Oct 2, 2024
* simple apis now cited/context doc indices * minor fixes
rajivml
pushed a commit
to UiPath/danswer
that referenced
this pull request
Oct 2, 2024
* simple apis now cited/context doc indices * minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.