Added ability to set timezone offset for Confluence connector in UI #3419
+31
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
requested changes
Dec 10, 2024
| "%Y-%m-%d %H:%M" | ||
| ) | ||
| # Convert float timestamps to datetime, then adjust for timezone | ||
| start_dt = datetime.fromtimestamp(start) + timedelta(hours=self.timezone_offset) |
There was a problem hiding this comment.
We should specify timezone here
|
About that; setting an offset will require us to update it when switching from/to Daylight Savings Time. EST => EDT, EDT => EST Setting the name of the timezone would be more permanent. Although... there should be a way to fix this without configuration! But I guess you are limited by the Confluence REST API somehow!? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.