Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: OONIAPIClientTest using failing API endpoint and incorrect testing logic #784

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

sdsantos
Copy link
Contributor

Fixes ooni/probe#2778

Proposed Changes

  • Switch testing endpoint from ams-pg.ooni.org to https://backend-hel.ooni.org
  • Refactor OONIAPIClientTest to Kotlin
  • Execute API calls synchronously to fix incorrect async logic
  • Remove database operations that were irrelevant to the testSelectMeasurementsWithJson test
  • Remove the test getMeasurementJsonError because it was only testing external libraries logic (retrofit and gson) and not the OONIAPIClient

Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@aanorbel aanorbel merged commit fffcea6 into master Jul 16, 2024
14 checks passed
@aanorbel aanorbel deleted the issue/2778 branch July 16, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

probe-android: OONIAPIClientTest is using a failing endpoint, but still passes
2 participants