Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: re-add support for riseupvpn #2560

Closed
bassosimone opened this issue Oct 11, 2023 · 1 comment · Fixed by ooni/probe-android#622 or ooni/probe-ios#534
Closed

mobile: re-add support for riseupvpn #2560

bassosimone opened this issue Oct 11, 2023 · 1 comment · Fixed by ooni/probe-android#622 or ooni/probe-ios#534
Assignees
Labels
cleanup There's need to cleanup stuff a bit ooni/probe-mobile issues related to OONI Probe mobile priority/medium

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Oct 11, 2023

In ooni/probe-cli#1365, I re-added riseupvpn as part of the experimental suite for probe-cli. We should do the same for mobile.

Note that now riseupvpn is a disabled-by-default experimental experiment that we can enable (or disable again) through the check-in API (so #2558 applies to this specific case).

Also, note that now the engine does not score riseupvpn results. We treat riseupvpn as an experiment that cannot really yield an anomaly but rather just as something we can use to collect useful data.

Therefore, we should make sure to remove any interpretation logic for riseupvpn from mobile apps (assuming there is any) and just use riseupvpn as the other experimental experiments.

@bassosimone bassosimone added ooni/probe-mobile issues related to OONI Probe mobile priority/medium cleanup There's need to cleanup stuff a bit releaseBlocker This issue blocks releasing labels Oct 11, 2023
@bassosimone
Copy link
Contributor Author

I'm removing the releaseBlocker flag because we determined with @aanorbel that this would cause us to delay the mobile release for too much time.

@bassosimone bassosimone removed the releaseBlocker This issue blocks releasing label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup There's need to cleanup stuff a bit ooni/probe-mobile issues related to OONI Probe mobile priority/medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants