Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky ResultTest and build config warnings #785

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix flaky ResultTest and build config warnings #785

merged 1 commit into from
Jul 17, 2024

Conversation

sdsantos
Copy link
Contributor

I haven't created a ticket for these changes.

Proposed Changes

  • Fix ResultTest.getLastResult by ensuring that the first result really has a start_time before the second result
  • Fix BuildConfig warning by changing to the new configuration
  • Remove the mockito-inline dependency, since it's no longer needed for Mockito 5

Context

aanorbel
aanorbel approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@aanorbel aanorbel merged commit 1b8924c into master Jul 17, 2024
14 checks passed
@aanorbel aanorbel deleted the fix/flaky-test-and-warnings branch July 17, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanorbel aanorbel aanorbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

probe-android: Many unit tests failing on the debug build type
2 participants
@sdsantos @aanorbel