Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profilling CPU usage, we're seeing a significant amount of waste that occurs because of the lazy
require()
calls that are then called repeatedly even after first load. There is still a non-trivial cost in looking up cached objects from the require cache, including calculating up and slicing up the full path to the file. When doing heavy XML building work, this can become a considerable burden.These changes simply shift all of the
require()
calls to the top so they are done once. In XMLNode.coffee they are lazily done in the constructor of the class, only the first time (by checking fornull
), so they are still just done once.