Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump revm version to ^v19.1.0 to include Isthmus operator fee feature #898

Open
leruaa opened this issue Jan 13, 2025 · 1 comment · May be fixed by #901
Open

Bump revm version to ^v19.1.0 to include Isthmus operator fee feature #898

leruaa opened this issue Jan 13, 2025 · 1 comment · May be fixed by #901

Comments

@leruaa
Copy link

leruaa commented Jan 13, 2025

In Isthmus, a new fee type has bee added: operator fee (See the specs). Some updates has been done in revm: bluealloy/revm#1960 and meged in v19.1.0

I think kona's revm dependency must be bumped to at least that version in order to continue to work once Isthmus is activated.
@sergerad sergerad linked a pull request Jan 14, 2025 that will close this issue
Draft
@sergerad
Copy link
Contributor

sergerad commented Jan 14, 2025 •
edited
Loading

@leruaa I have created a PR to get the ball rolling. Currently wondering how to best handle the new arg parent_target_blob_gas_per_block.

If we want to ignore pectra in Kona for now, we could copy over these from previous revm release. AFAICT, the later release doesn't provide those anymore.

But we might want logic to toggle between dencun/pectra values. I lack context around that.

TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump revm to 19.3.0 sergerad/kona
2 participants
@leruaa @sergerad