Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(executor): Re-introduce static testdata #917

Closed
clabby opened this issue Jan 22, 2025 · 0 comments · Fixed by #938
Closed

chore(executor): Re-introduce static testdata #917

clabby opened this issue Jan 22, 2025 · 0 comments · Fixed by #938
Assignees
Labels
A-executor Area: kona-executor crate K-chore Kind: chore M-tests Meta: Testing related

Comments

@clabby
Copy link
Collaborator

clabby commented Jan 22, 2025

Overview

With a recent update to revm, our static test data no longer worked, likely due to a new load of an account during execution in revm's hotpath. This broke the static unit tests we had for the executor, working off of compressed witness databases that were embedded into the repository.

We should re-introduce these tests, which were temporarily removed in #910. Also, we should check in a tool to create these test vectors easily, so that potential blocks that cause regressions can be trivially converted to a static test in the repository.

@clabby clabby added A-executor Area: kona-executor crate K-chore Kind: chore M-tests Meta: Testing related labels Jan 22, 2025
@clabby clabby self-assigned this Jan 22, 2025
@emhane emhane moved this from Backlog to Done in Project Tracking Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-executor Area: kona-executor crate K-chore Kind: chore M-tests Meta: Testing related
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant