Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics.summarize_raw trying to access non existent attribute from ResultSet #820

Open
Zapiano opened this issue Aug 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Zapiano
Copy link
Collaborator

Zapiano commented Aug 9, 2024

This function tries to access rs.raw, which doesn't exist.

return summarize_raw(rs.raw; kwargs...)

I'm not sure if this function should be deleted or modified. I am also not sure what rs.raw is supposed to be.

@Zapiano Zapiano added the bug Something isn't working label Aug 9, 2024
@ConnectedSystems
Copy link
Collaborator

ConnectedSystems commented Aug 9, 2024

Wow, this is very old.

The run_model() interface function returns a namedtuple, in which one of the fields holds the raw results.
Horrible name, but at the time I was thinking an "ecosystem model" may not be concerned only with coral cover, hence it would return the "raw" unprocessed results from a model.

Circa 2 years ago, there was a corresponding field in the Result Set, which I think we've renamed to something more appropriate like "relative cover"...

All this said, all the code in this file needs to be updated or removed. The use cases have shifted compared to two years ago. I'm thinking we can do most, if not all, the same things with the current set of scenario-based metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants