Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DIS_DR_* and DIS_DeadReckoning classes #82

Closed
leif81 opened this issue May 6, 2022 · 1 comment · Fixed by #85
Closed

Deprecate DIS_DR_* and DIS_DeadReckoning classes #82

leif81 opened this issue May 6, 2022 · 1 comment · Fixed by #85
Assignees

Comments

@leif81
Copy link
Member

leif81 commented May 6, 2022

In general, I think the previous Dead Reckoning DIS_DR_* implementation should be deprecated in favor of the single DIS_DeadReckoning class I recently added. For example, the previous DIS_DR_* implementations have thread safety issues #41.

Originally posted by @camejia in #42 (comment)

I believe Chris made a typo in that comment and was recommending use of the DeadReckoner class he wrote instead of the DIS_DeadReckoning and DIS_DR_* classes.:

https://github.com/open-dis/open-dis-java/blob/master/src/main/java/edu/nps/moves/deadreckoning/DeadReckoner.java

Another advantage of DeadReckoner is that it has extensive unit tests:

https://github.com/open-dis/open-dis-java/blob/master/src/test/java/edu/nps/moves/deadreckoning/DeadReckonerTest.java

Other issues affecting the classes to be deprecated:

@leif81
Copy link
Member Author

leif81 commented Jul 29, 2022

If anyone has concerns with this sugestion can you please share. For example if you are using the original DIS_DR_* implementation and cannot for some reason migrate to the DeadReckoner. Could you please share your thoughts. Thanks.

@leif81 leif81 self-assigned this Aug 22, 2022
@leif81 leif81 linked a pull request Aug 22, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant