Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeadReckoner:perform_DR() for (some) articulated parts not working #86

Closed
LumHwang opened this issue Oct 24, 2022 · 1 comment · Fixed by #87
Closed

DeadReckoner:perform_DR() for (some) articulated parts not working #86

LumHwang opened this issue Oct 24, 2022 · 1 comment · Fixed by #87
Assignees
Labels

Comments

@LumHwang
Copy link
Contributor

We are using articulated parts parameters:

  1. Turret Azimuth
    PRIMARY_TURRET_NUMBER_1 + AZIMUTH
  2. Gun Elevation (attached to turret)
    PRIMARY_GUN_NUMBER_1 + ELEVATION

When perform_DR() is called on those parts, the values produced for turret Azimuth seem correct at certain angles, but at other angles, the values flip/flop (even when there is no movement).

In the end, I think that dead-reckoning for those parts should be disabled.

@leif81 leif81 linked a pull request Oct 24, 2022 that will close this issue
@leif81 leif81 added the bug label Oct 24, 2022
@leif81
Copy link
Member

leif81 commented Nov 9, 2022

Thank-you for the report @LumHwang . Will await confirmation the change passed lab testing and then will proceed with merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants