Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EntityMarking seems unimplemented #13

Closed
joeclarkia opened this issue Dec 14, 2022 · 2 comments · Fixed by #14
Closed

EntityMarking seems unimplemented #13

joeclarkia opened this issue Dec 14, 2022 · 2 comments · Fixed by #14
Labels
bug

Comments

@joeclarkia
Copy link
Contributor

The dis7 EntityMarking.js files implements the marking character string as a single byte, instead of the specified 12 bytes (11 + NULL terminator). I have sample code that I believe will implement this correctly -- I will aim to commit this code to a forked repo (or I could put a patch here) for consideration.
@leif81
Copy link
Member

leif81 commented Dec 15, 2022

Thank-you @joeclarkia . Yes if you believe it's a bug we always welcome and encourage pull requests to fix them!

@joeclarkia
Copy link
Contributor Author

joeclarkia commented Dec 15, 2022 •
edited
Loading

Pull Request: #14

@leif81 leif81 added the bug label Dec 15, 2022
@leif81 leif81 linked a pull request Jan 10, 2023 that will close this issue
Feature/entity marking fix #14
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/entity marking fix joeclarkia/open-dis-javascript
2 participants
@leif81 @joeclarkia