Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityMarking: characters array length is wrong #21

Closed
joeclarkia opened this issue Jul 18, 2023 · 2 comments · Fixed by #23
Closed

EntityMarking: characters array length is wrong #21

joeclarkia opened this issue Jul 18, 2023 · 2 comments · Fixed by #23
Labels

Comments

@joeclarkia
Copy link
Contributor

https://github.com/open-dis/open-dis-javascript/blob/master/src/dis7/EntityMarking.js#L26

The character array length is set to 12, but according to the standard, it should be 11. This is an easy mistake because the total EntityMarking length is 12, but the first byte is a character set byte.

Sidenote: I was interested to submit this, my second issue/codefix for open-dis-javascript. I was a little less excited when I realized that I was the one who introduced this bug -- oops!

@leif81 leif81 added the bug label Jul 21, 2023
@leif81
Copy link
Member

leif81 commented Jul 21, 2023

Thanks for the report @joeclarkia

Will you be interested in submitting a pull request?

@joeclarkia
Copy link
Contributor Author

#23

I think that's all that is required to fix this.

@leif81 leif81 linked a pull request Jul 21, 2023 that will close this issue
@leif81 leif81 closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants