Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating ES6/TypeScript #26

Open
cplpearce opened this issue Oct 6, 2023 · 5 comments
Open

Integrating ES6/TypeScript #26

cplpearce opened this issue Oct 6, 2023 · 5 comments

Comments

@cplpearce
Copy link

Hello!

Our team is looking at integrating this library into a TypeScript frontend project.

We would like to begin building out a TypeScript compliant branch and just wanted to check if any of the maintainers have any comments, questions or suggestions before we begin.

We would like to keep it OS, hosted in this repo if possible!

Thanks!

@B1Dobbs
Copy link

B1Dobbs commented Sep 16, 2024

Hi @cplpearce, how far along are you on supporting TypeScript right now?

Our team has also been using this project in more modern front-end application and we have a current implementation of generating types from the JSDoc annotations using tsd-jsdoc. This method allows for the current JavaScript to remain relatively untouched while also supporting TypeScript.

We were going to open a PR here soon with the type generation script and JSDoc annotation updates. There would also be a separate PR in DefinitelyTyped to add a new open-dis module. It would be installed like other type modules: npm install --save-dev @types/open-dis.

@jfelicianiats
Copy link

Has there been any updates on this?
@B1Dobbs Any update on PR'ing these types?

@B1Dobbs
Copy link

B1Dobbs commented Jan 30, 2025

@jfelicianiats I've built the types and have been using them locally for a while in our own TS projects. Kind of dropped the ball on getting it in a PR. I could get it pushed next week though if it's needed!

@leif81 Is there any preference to having the types directly in this repository or published through DefinitelyTyped?

@leif81
Copy link
Member

leif81 commented Jan 31, 2025

@B1Dobbs a PR as described earlier seems like a good approach. But am open to suggestions.

We were going to open a PR here soon with the type generation script and JSDoc annotation updates. There would also be a separate PR in DefinitelyTyped to add a new open-dis module. It would be installed like other type modules: npm install --save-dev @types/open-dis.

@jfelicianiats
Copy link

@B1Dobbs Thanks for making a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants