-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split errors to classes by types #115
Conversation
Signed-off-by: Valentinas <31697821+valentk777@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 94.54% 90.95% -3.60%
==========================================
Files 20 27 +7
Lines 532 553 +21
Branches 37 37
==========================================
Hits 503 503
- Misses 16 37 +21
Partials 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I would just recommend that you remove the section line in each summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codecov has failed, but I don't think coverage of this sort of change is valuable.
Thanks @valentk777 . I agree with @beeme1mr suggestions, but otherwise looks good!
Signed-off-by: Valentinas <31697821+valentk777@users.noreply.github.com>
Thank you for your reviews. Code updated. |
Signed-off-by: Valentinas 31697821+valentk777@users.noreply.github.com
In this PR, I created a separate class for each error type.
Fixes #110