Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split errors to classes by types #115

Merged
merged 2 commits into from
Feb 13, 2023
Merged

feat: split errors to classes by types #115

merged 2 commits into from
Feb 13, 2023

Conversation

valentk777
Copy link
Contributor

@valentk777 valentk777 commented Feb 7, 2023

Signed-off-by: Valentinas 31697821+valentk777@users.noreply.github.com

In this PR, I created a separate class for each error type.

Fixes #110

Signed-off-by: Valentinas <31697821+valentk777@users.noreply.github.com>
@beeme1mr beeme1mr requested review from toddbaert and benjiro February 9, 2023 18:16
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #115 (7a4c306) into main (bd730a5) will decrease coverage by 3.60%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   94.54%   90.95%   -3.60%     
==========================================
  Files          20       27       +7     
  Lines         532      553      +21     
  Branches       37       37              
==========================================
  Hits          503      503              
- Misses         16       37      +21     
  Partials       13       13              
Impacted Files Coverage Δ
src/OpenFeature/Error/FeatureProviderException.cs 100.00% <ø> (ø)
src/OpenFeature/Error/FlagNotFoundException.cs 0.00% <0.00%> (ø)
src/OpenFeature/Error/GeneralException.cs 0.00% <0.00%> (ø)
src/OpenFeature/Error/InvalidContextException.cs 0.00% <0.00%> (ø)
src/OpenFeature/Error/ParseErrorException.cs 0.00% <0.00%> (ø)
src/OpenFeature/Error/ProviderNotReadyException.cs 0.00% <0.00%> (ø)
.../OpenFeature/Error/TargetingKeyMissingException.cs 0.00% <0.00%> (ø)
src/OpenFeature/Error/TypeMismatchException.cs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would just recommend that you remove the section line in each summary.

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov has failed, but I don't think coverage of this sort of change is valuable.

Thanks @valentk777 . I agree with @beeme1mr suggestions, but otherwise looks good!

@toddbaert toddbaert requested a review from kinyoklion February 9, 2023 20:23
Signed-off-by: Valentinas <31697821+valentk777@users.noreply.github.com>
@valentk777
Copy link
Contributor Author

Thank you for your reviews. Code updated.

@beeme1mr beeme1mr merged commit 5f348f4 into open-feature:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] implement standard error classes
4 participants