Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for eventing #166

Merged
merged 31 commits into from
Jan 16, 2024
Merged

feat: add support for eventing #166

merged 31 commits into from
Jan 16, 2024

Conversation

bacherfl
Copy link
Contributor

@bacherfl bacherfl commented Jan 2, 2024

This PR adds support for Eventing and thus solves a part of #126

Note: I had to add some Thread.Sleeps in the unit tests to verify the event handlers, which are called by a separate thread, are called eventually. Coming from a Golang background, I would have liked to have something like require.Eventually, but I did not find anything similar for dotnet. If anyone with more dotnet experience knows how to do this in a better way, I appreciate any suggestions :)

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (24c3441) 94.30% compared to head (2494599) 94.73%.
Report is 6 commits behind head on main.

Files Patch % Lines
src/OpenFeature/EventExecutor.cs 95.29% 6 Missing and 6 partials ⚠️
src/OpenFeature/Api.cs 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   94.30%   94.73%   +0.42%     
==========================================
  Files          21       23       +2     
  Lines         650      931     +281     
  Branches       54       93      +39     
==========================================
+ Hits          613      882     +269     
- Misses         23       29       +6     
- Partials       14       20       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl marked this pull request as ready for review January 3, 2024 11:59
@bacherfl bacherfl requested a review from a team as a code owner January 3, 2024 11:59
README.md Outdated Show resolved Hide resolved
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great job! Excellent testing and very readable overall. Left a few comments. I think my only blocker is the test I described here.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bacherfl ! Recent changes have me satisfied.

@Kavindu-Dodan
Copy link

Approved the PR. Feel free to resolve my comments and merge. Nice work @bacherfl 🎉

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@toddbaert
Copy link
Member

toddbaert commented Jan 12, 2024

I'll merge this EOD Tuesday next week unless I hear objections!

I think we can then consider our pending 2.0 release.

@toddbaert toddbaert merged commit f5fc1dd into main Jan 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants