Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce OpenFeature.Extensions.Hosting package #264

Open
austindrenski opened this issue Jan 8, 2024 · 0 comments · May be fixed by #181
Open

Introduce OpenFeature.Extensions.Hosting package #264

austindrenski opened this issue Jan 8, 2024 · 0 comments · May be fixed by #181
Assignees
@askpt @austindrenski
Labels
enhancement New feature or request
Milestone
2.0 (breaking)

Comments

@austindrenski
Copy link
Member

austindrenski commented Jan 8, 2024 •
edited
Loading

I'm eventually planning to offer this upstream as part of a new OpenFeature.Extensions.Hosting package à la OpenTelemetry.Extensions.Hosting, but still working through the realistic use cases and general ergonomics, but just mentioning that so this doesn't seem entirely irrelevant to the project at hand.

This has been suggested before, and I think it's a good idea. I would welcome such a PR, or at least an issue proposing it.

I'll open a new issue to track this, and will see about getting a draft PR put together over the next couple of weeks.

Originally posted by @austindrenski in open-feature/dotnet-sdk-contrib#125 (comment)
@austindrenski austindrenski mentioned this issue Jan 8, 2024
Closed
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
Reduce dependency on MEL -> MELA
f21dc35 
Ran across this while working on open-feature/dotnet-sdk-contrib#127,
but tldr; libraries don't need the implementation package, so reduce
to the abstractions package to remove transitive dependencies on:

- Microsoft.Extensions.DependencyInjection
- Microsoft.Extensions.Options
- (and a few others depending on the TFM)

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
Reduce dependency on MEL -> MELA
52a4b6e 
Ran across this while working on open-feature/dotnet-sdk-contrib#127,
but tldr; libraries don't need the implementation package, so reduce
to the abstractions package to remove transitive dependencies on:

- Microsoft.Extensions.DependencyInjection
- Microsoft.Extensions.Options
- (and a few others depending on the TFM)

Signed-off-by: Austin Drenski <austin@austindrenski.io>
@austindrenski austindrenski mentioned this issue Jan 16, 2024
Merged
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
chore: Fix props to supprot more than one project
488d607 
Ran across this while working on open-feature/dotnet-sdk-contrib#127,
and tldr; if there's more than one project under `src/`, having the
`<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild
to panic.

There are two options to fix this:

1. ```diff
   - <PackageId>OpenFeature</PackageId>
   + <PackageId>$(MSBuildProjectName)</PackageId>
   ```
2. ```diff
   - <PackageId>OpenFeature</PackageId>
   ```

Since NuGet defaults `PackageId` to the assembly name, I'm opting
for (2), but if I've overlooked some nuance/custom build steps that
require setting `PackageId` explicitly, then we could just as well
fallback to (1).

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
chore: Reduce dependency on MEL -> MELA
36791a6 
Ran across this while working on open-feature/dotnet-sdk-contrib#127,
but tldr; libraries don't need the implementation package, so reduce
to the abstractions package to remove transitive dependencies on:

- Microsoft.Extensions.DependencyInjection
- Microsoft.Extensions.Options
- (and a few others depending on the TFM)

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
chore: Fix props to support more than one project
0262329 
Ran across this while working on open-feature/dotnet-sdk-contrib#127,
and tldr; if there's more than one project under `src/`, having the
`<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild
to panic.

There are two options to fix this:

1. ```diff
   - <PackageId>OpenFeature</PackageId>
   + <PackageId>$(MSBuildProjectName)</PackageId>
   ```
2. ```diff
   - <PackageId>OpenFeature</PackageId>
   ```

Since NuGet defaults `PackageId` to the assembly name, I'm opting
for (2), but if I've overlooked some nuance/custom build steps that
require setting `PackageId` explicitly, then we could just as well
fallback to (1).

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
chore: Fix props to support more than one project
90407e8 
Ran across this while working on open-feature/dotnet-sdk-contrib#127,
and tldr; if there's more than one project under `src/`, having the
`<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild
to panic.

There are two options to fix this:

1. ```diff
   - <PackageId>OpenFeature</PackageId>
   + <PackageId>$(MSBuildProjectName)</PackageId>
   ```
2. ```diff
   - <PackageId>OpenFeature</PackageId>
   ```

Since NuGet defaults `PackageId` to the assembly name, I'm opting
for (2), but if I've overlooked some nuance/custom build steps that
require setting `PackageId` explicitly, then we could just as well
fallback to (1).

Signed-off-by: Austin Drenski <austin@austindrenski.io>
This was referenced Jan 16, 2024
Merged
Merged
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
chore: Fix props to support more than one project
37f7d10 
Ran across this while working on open-feature/dotnet-sdk-contrib#127,
and tldr; if there's more than one project under `src/`, having the
`<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild
to panic.

There are two options to fix this:

1. ```diff
   - <PackageId>OpenFeature</PackageId>
   + <PackageId>$(MSBuildProjectName)</PackageId>
   ```
2. ```diff
   - <PackageId>OpenFeature</PackageId>
   ```

Since NuGet defaults `PackageId` to the assembly name, I'm opting
for (2), but if I've overlooked some nuance/custom build steps that
require setting `PackageId` explicitly, then we could just as well
fallback to (1).

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
Add OpenFeature.Extensions.Hosting package
53fdc1f 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
b5fa35e 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
7d00728 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
a8abba9 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
ffbb98f 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
@austindrenski austindrenski linked a pull request Jan 16, 2024 that will close this issue
Draft
10 tasks
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
68cd53f 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
87e8bdf 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
67c39fc 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
c798fc8 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 16, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
c295dd0 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
@austindrenski austindrenski mentioned this issue Jan 16, 2024
Closed
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 17, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
aa8544b 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 17, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
a9fd12e 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 17, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
9821a5b 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 17, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
2eb7335 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 19, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
828cebb 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 19, 2024
@austindrenski
chore: Fix props to support more than one project
cbd22d9 
Ran across this while working on open-feature/dotnet-sdk-contrib#127,
and tldr; if there's more than one project under `src/`, having the
`<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild
to panic.

There are two options to fix this:

1. ```diff
   - <PackageId>OpenFeature</PackageId>
   + <PackageId>$(MSBuildProjectName)</PackageId>
   ```
2. ```diff
   - <PackageId>OpenFeature</PackageId>
   ```

Since NuGet defaults `PackageId` to the assembly name, I'm opting
for (2), but if I've overlooked some nuance/custom build steps that
require setting `PackageId` explicitly, then we could just as well
fallback to (1).

Signed-off-by: Austin Drenski <austin@austindrenski.io>
toddbaert referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 19, 2024
@austindrenski @toddbaert
chore: Fix props to support more than one project
71230e8 
Ran across this while working on open-feature/dotnet-sdk-contrib#127,
and tldr; if there's more than one project under `src/`, having the
`<PackageId>` hard-coded in `build/Common.prod.props` causes MSBuild
to panic.

There are two options to fix this:

1. ```diff
   - <PackageId>OpenFeature</PackageId>
   + <PackageId>$(MSBuildProjectName)</PackageId>
   ```
2. ```diff
   - <PackageId>OpenFeature</PackageId>
   ```

Since NuGet defaults `PackageId` to the assembly name, I'm opting
for (2), but if I've overlooked some nuance/custom build steps that
require setting `PackageId` explicitly, then we could just as well
fallback to (1).

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 20, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
cf419bd 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 22, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
ce04b0f 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 23, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
83850e7 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 23, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
01c76d9 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 23, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
8f36c66 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 23, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
ad140a2 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 23, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
7fb289d 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 27, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
a2cde68 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 27, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
66e10b1 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 27, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
2422211 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski referenced this issue in austindrenski/open-feature-dotnet-sdk Jan 29, 2024
@austindrenski
feat: Add OpenFeature.Extensions.Hosting package
bcf19c4 
See: open-feature/dotnet-sdk-contrib#127

Signed-off-by: Austin Drenski <austin@austindrenski.io>
@julealgon julealgon mentioned this issue Feb 12, 2024
Open
@askpt askpt transferred this issue from open-feature/dotnet-sdk-contrib Apr 24, 2024
@askpt askpt added the enhancement New feature or request label Apr 24, 2024
@askpt askpt added this to the 2.0 (breaking) milestone Apr 24, 2024
@askpt askpt self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@askpt askpt

@austindrenski austindrenski

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0 (breaking)
Development

Successfully merging a pull request may close this issue.

feat: Add OpenFeature.Extensions.Hosting package austindrenski/open-feature-dotnet-sdk
2 participants
@askpt @austindrenski