Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release 1.0.0 #85

Merged
merged 1 commit into from
Oct 21, 2022
Merged

chore: release 1.0.0 #85

merged 1 commit into from
Oct 21, 2022

Conversation

toddbaert
Copy link
Member

Release-As: 1.0.0

@toddbaert
chore: release 1.0.0
ea1b9e6 
Release-As: 1.0.0
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert
Copy link
Member Author

toddbaert commented Oct 18, 2022 •
edited
Loading

⚠️ Merging this commit (!without any change to the body!) will cause Release Please to open a 1.0 release PR. ⚠️

beeme1mr
beeme1mr approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this just opens a proper release PR.

weyert
weyert approved these changes Oct 19, 2022
View reviewed changes
Copy link

@weyert weyert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its looking great.

Only suggestion I would help whether it would be worthwhile to add a logging hook as an example?

@toddbaert
Copy link
Member Author

I think its looking great.

Only suggestion I would help whether it would be worthwhile to add a logging hook as an example?

Good call out.

I actually have a separate PR that adds a link to the doc where we have extensive code examples and explanations of hooks:
#86

https://docs.openfeature.dev/docs/reference/concepts/hooks

kinyoklion
kinyoklion approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@kinyoklion kinyoklion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good to me. I am not as familiar with the documentation or other procedural elements, but I don't have any major code concerns at this point,

@toddbaert
Copy link
Member Author

Merging this. We can have any required discussion about what follow ups we want in the subsequent release PR that will get created.

@toddbaert toddbaert merged commit 79c0d8d into main Oct 21, 2022
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Merged
benjiro pushed a commit that referenced this pull request Oct 26, 2022
@github-actions
chore(main): release 1.0.0 (#87)
a6363bd 
🤖 I have created a release *beep* *boop*
---


##
[1.0.0](v0.5.0...v1.0.0)
(2022-10-21)


### Miscellaneous Chores

* release 1.0.0
([#85](#85))
([79c0d8d](79c0d8d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jan 18, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyert weyert weyert approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@benjiro benjiro benjiro approved these changes

@kinyoklion kinyoklion kinyoklion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toddbaert @weyert @beeme1mr @benjiro @kinyoklion