From 0c3af2da01f91f6fc6d5ac78a33dd79032537ea9 Mon Sep 17 00:00:00 2001 From: Todd Baert Date: Thu, 2 Nov 2023 10:08:21 -0400 Subject: [PATCH] chore: fix lint errors (#987) Fixes a few lint issues, directly, and by ignoring some submodules. --------- Signed-off-by: Todd Baert --- .golangci.yml | 2 ++ flagd/cmd/start.go | 13 +++++++------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index d1abfe4f4..f960f9f1a 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -2,6 +2,8 @@ run: skip-dirs: - (^|/)bin($|/) - (^|/)examples($|/) + - (^|/)schemas($|/) + - (^|/)test-harness($|/) linters: enable: - asciicheck diff --git a/flagd/cmd/start.go b/flagd/cmd/start.go index ea135f2ac..44d52f9c6 100644 --- a/flagd/cmd/start.go +++ b/flagd/cmd/start.go @@ -29,6 +29,7 @@ const ( sourcesFlagName = "sources" syncProviderFlagName = "sync-provider" uriFlagName = "uri" + docsLinkConfiguration = "https://flagd.dev/reference/flagd-cli/flagd_start/" defaultServicePort = 8013 defaultMetricsPort = 8014 @@ -117,18 +118,18 @@ var startCmd = &cobra.Command{ rtLogger.Info(fmt.Sprintf("flagd version: %s (%s), built at: %s", Version, Commit, Date)) if viper.GetString(syncProviderFlagName) != "" { - rtLogger.Warn("DEPRECATED: The --sync-provider flag has been deprecated. " + - "Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration/configuration.md") + rtLogger.Warn("DEPRECATED: The --sync-provider flag has been deprecated, see: " + + docsLinkConfiguration) } if viper.GetString(evaluatorFlagName) != "json" { - rtLogger.Warn("DEPRECATED: The --evaluator flag has been deprecated. " + - "Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration/configuration.md") + rtLogger.Warn("DEPRECATED: The --evaluator flag has been deprecated, see: " + + docsLinkConfiguration) } if viper.GetString(providerArgsFlagName) != "" { - rtLogger.Warn("DEPRECATED: The --sync-provider-args flag has been deprecated. " + - "Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration/configuration.md") + rtLogger.Warn("DEPRECATED: The --sync-provider-args flag has been deprecated, see: " + + docsLinkConfiguration) } syncProviders, err := runtime.ParseSyncProviderURIs(viper.GetStringSlice(uriFlagName))