Skip to content

Commit

Permalink
chore: disable caching tests in CI (#442)
Browse files Browse the repository at this point in the history
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
  • Loading branch information
skyerus authored Feb 27, 2023
1 parent 7f2358c commit 28a35f6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ jobs:
with:
sarif_file: "trivy-results.sarif"

integration-test:
integration-test: # caching tests are disabled due to slow file I/O in github actions
runs-on: ubuntu-latest

steps:
Expand All @@ -153,5 +153,5 @@ jobs:
- name: Run flagd binary in background
run: ./flagd start -f file:${{ github.workspace }}/test-harness/symlink_testing-flags.json &

- name: Run tests
run: make integration-test
- name: Run evaluation test suite
run: go test -cover ./tests/integration -run TestEvaluation
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ require (
github.com/golang/mock v1.6.0
github.com/mattn/go-colorable v0.1.13
github.com/open-feature/go-sdk-contrib/providers/flagd v0.1.7
github.com/open-feature/go-sdk-contrib/tests/flagd v1.2.0
github.com/open-feature/go-sdk-contrib/tests/flagd v1.2.1
github.com/open-feature/open-feature-operator v0.2.28
github.com/open-feature/schemas v0.2.8
github.com/prometheus/client_golang v1.14.0
Expand Down
6 changes: 2 additions & 4 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,8 @@ github.com/open-feature/go-sdk v1.1.0 h1:JOOa0AleJFUvnWoF9KWdLqYosi5fDIRBDzPYZPr
github.com/open-feature/go-sdk v1.1.0/go.mod h1:R8QJmLdSHFaRdrWtwmp5bVK35Q+O/cEGtYaiy6NM6kc=
github.com/open-feature/go-sdk-contrib/providers/flagd v0.1.7 h1:0s8reX/EfCNV37PsGSr55wUpppPtyp0jZKeuVAaWZ+4=
github.com/open-feature/go-sdk-contrib/providers/flagd v0.1.7/go.mod h1:dHB0hsYykZ1Un+CdnWErqLqUQswUADIvDg2VwDLx7gs=
github.com/open-feature/go-sdk-contrib/tests/flagd v1.1.0 h1:lM+7hfFVwUxQPOyJ9rXn2UR4sCAfOQJKtCU29pU/B+4=
github.com/open-feature/go-sdk-contrib/tests/flagd v1.1.0/go.mod h1:zw/xpuDy9ziBEKVA1t4VoQtzFc80btAAQCiZkX6y9oQ=
github.com/open-feature/go-sdk-contrib/tests/flagd v1.2.0 h1:PBCaJIK6fb5+27m+yBEmjIkLRJ+yZx72mHjcrcy73+Y=
github.com/open-feature/go-sdk-contrib/tests/flagd v1.2.0/go.mod h1:zw/xpuDy9ziBEKVA1t4VoQtzFc80btAAQCiZkX6y9oQ=
github.com/open-feature/go-sdk-contrib/tests/flagd v1.2.1 h1:Tg712Egcqb5dsYxOGEaQbfD3g1mqPFdV4tSmKKKxDPk=
github.com/open-feature/go-sdk-contrib/tests/flagd v1.2.1/go.mod h1:zw/xpuDy9ziBEKVA1t4VoQtzFc80btAAQCiZkX6y9oQ=
github.com/open-feature/open-feature-operator v0.2.28 h1:qzzVq8v9G7aXO7luocO/wQCGnTJjtcQh75mDOqjnFxo=
github.com/open-feature/open-feature-operator v0.2.28/go.mod h1:bQncVK7hvhj5QStPwexxQ1aArPwox2Y1vWrVei/qIFg=
github.com/open-feature/schemas v0.2.8 h1:oA75hJXpOd9SFgmNI2IAxWZkwzQPUDm7Jyyh3q489wM=
Expand Down

1 comment on commit 28a35f6

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: 28a35f6 Previous: 04014e7 Ratio
BenchmarkResolveBooleanValue/test_staticBoolFlag 1770 ns/op 96 B/op 4 allocs/op 1277 ns/op 96 B/op 4 allocs/op 1.39
BenchmarkResolveBooleanValue/test_targetingBoolFlag 20004 ns/op 4817 B/op 80 allocs/op 12543 ns/op 4817 B/op 80 allocs/op 1.59
BenchmarkResolveBooleanValue/test_staticObjectFlag 1649 ns/op 96 B/op 4 allocs/op 1222 ns/op 96 B/op 4 allocs/op 1.35
BenchmarkResolveBooleanValue/test_missingFlag 2035 ns/op 160 B/op 6 allocs/op 1418 ns/op 160 B/op 6 allocs/op 1.44
BenchmarkResolveBooleanValue/test_disabledFlag 1858 ns/op 160 B/op 6 allocs/op 1412 ns/op 160 B/op 6 allocs/op 1.32
BenchmarkResolveStringValue/test_staticStringFlag 1856 ns/op 128 B/op 6 allocs/op 1353 ns/op 128 B/op 6 allocs/op 1.37
BenchmarkResolveStringValue/test_targetingStringFlag 19609 ns/op 4841 B/op 82 allocs/op 12218 ns/op 4841 B/op 82 allocs/op 1.60
BenchmarkResolveStringValue/test_staticObjectFlag 1657 ns/op 96 B/op 4 allocs/op 1224 ns/op 96 B/op 4 allocs/op 1.35
BenchmarkResolveStringValue/test_missingFlag 1995 ns/op 160 B/op 6 allocs/op 1413 ns/op 160 B/op 6 allocs/op 1.41
BenchmarkResolveStringValue/test_disabledFlag 1893 ns/op 160 B/op 6 allocs/op 1430 ns/op 160 B/op 6 allocs/op 1.32
BenchmarkResolveIntValue/test_staticIntFlag 1758 ns/op 96 B/op 4 allocs/op 1286 ns/op 96 B/op 4 allocs/op 1.37
BenchmarkResolveIntValue/test_targetingNumberFlag 17663 ns/op 4825 B/op 80 allocs/op 11332 ns/op 4825 B/op 80 allocs/op 1.56
BenchmarkResolveIntValue/test_staticObjectFlag 1600 ns/op 96 B/op 4 allocs/op 1223 ns/op 96 B/op 4 allocs/op 1.31
BenchmarkResolveIntValue/test_missingFlag 2013 ns/op 144 B/op 6 allocs/op 1413 ns/op 144 B/op 6 allocs/op 1.42
BenchmarkResolveIntValue/test_disabledFlag 1875 ns/op 160 B/op 6 allocs/op 1414 ns/op 160 B/op 6 allocs/op 1.33
BenchmarkResolveObjectValue/test_staticObjectFlag 6626 ns/op 1392 B/op 32 allocs/op 5012 ns/op 1392 B/op 32 allocs/op 1.32
BenchmarkResolveObjectValue/test_targetingObjectFlag 24431 ns/op 6106 B/op 104 allocs/op 15701 ns/op 6106 B/op 104 allocs/op 1.56
BenchmarkResolveObjectValue/test_staticBoolFlag 1632 ns/op 96 B/op 4 allocs/op 1226 ns/op 96 B/op 4 allocs/op 1.33
BenchmarkResolveObjectValue/test_missingFlag 1998 ns/op 160 B/op 6 allocs/op 1424 ns/op 160 B/op 6 allocs/op 1.40
BenchmarkResolveObjectValue/test_disabledFlag 1850 ns/op 160 B/op 6 allocs/op 1417 ns/op 160 B/op 6 allocs/op 1.31
BenchmarkConnectService_ResolveString/happy_path 3739 ns/op 496 B/op 12 allocs/op 2841 ns/op 496 B/op 12 allocs/op 1.32
BenchmarkConnectService_ResolveInt/happy_path 3690 ns/op 480 B/op 12 allocs/op 2824 ns/op 480 B/op 12 allocs/op 1.31
BenchmarkConnectService_ResolveObject/happy_path 5550 ns/op 1640 B/op 27 allocs/op 4198 ns/op 1640 B/op 27 allocs/op 1.32

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.