From 1bfb321e3f9a8761ea06156e4b241a281cf3b533 Mon Sep 17 00:00:00 2001 From: James Milligan <75740990+james-milligan@users.noreply.github.com> Date: Wed, 25 Jan 2023 16:14:41 +0000 Subject: [PATCH 1/7] docs: fixed typo (#319) Signed-off-by: James Milligan --- docs/configuration/flag_configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/configuration/flag_configuration.md b/docs/configuration/flag_configuration.md index 6acf43c2c..adb9d0844 100644 --- a/docs/configuration/flag_configuration.md +++ b/docs/configuration/flag_configuration.md @@ -18,7 +18,7 @@ Example: ### Variants -`variants` is a **required** property. It is an object containing the possible variations supported by the flag. All the values of the object **must** but the same type (e.g. boolean, numbers, string, JSON). The type used as the variant value will correspond directly affects how the flag is accessed. For example, to use a flag configured with boolean values the `/schema.v1.Service/ResolveBoolean` path should be used. If another path such as `/schema.v1.Service/ResolveString` is called, a type mismatch occurred and an error is returned. +`variants` is a **required** property. It is an object containing the possible variations supported by the flag. All the values of the object **must** be the same type (e.g. boolean, numbers, string, JSON). The type used as the variant value will correspond directly affects how the flag is accessed. For example, to use a flag configured with boolean values the `/schema.v1.Service/ResolveBoolean` path should be used. If another path such as `/schema.v1.Service/ResolveString` is called, a type mismatch occurred and an error is returned. Example: From a2630dbba151f35cc985d38de9cf25bfee2b76c8 Mon Sep 17 00:00:00 2001 From: James Milligan <75740990+james-milligan@users.noreply.github.com> Date: Wed, 25 Jan 2023 16:32:43 +0000 Subject: [PATCH 2/7] fix: deprecation warning fix (#317) Signed-off-by: jamesmilligan ## This PR - fixes incorrect default on deprecation warning, preventing warning log when the flag is not used ### Related Issues ### Notes ### Follow-up Tasks ### How to test Signed-off-by: jamesmilligan Co-authored-by: Michael Beemer --- cmd/start.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/start.go b/cmd/start.go index 53b587d0e..96d515469 100644 --- a/cmd/start.go +++ b/cmd/start.go @@ -95,7 +95,7 @@ var startCmd = &cobra.Command{ "Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration.md") } - if viper.GetString(evaluatorFlagName) != "" { + if viper.GetString(evaluatorFlagName) != "json" { rtLogger.Warn("DEPRECATED: The --evaluator flag has been deprecated. " + "Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration.md") } From 0e8e2c5bcb7c68debea5112f2b15e50c6468eb4d Mon Sep 17 00:00:00 2001 From: Rui Chen Date: Wed, 25 Jan 2023 12:05:44 -0500 Subject: [PATCH 3/7] ci(release): add homebrew-core bump step (#311) ## This PR - feat(release): add homebrew-core bump step ### Related Issues Fixes #306 ### Notes Two TODOs with this PR: - [x] Need to create a homebrew-core fork for which PAT token can access (https://github.com/open-feature/homebrew-core) - [x] Need to create a repo scope token for this `COMMITTER_TOKEN` token ### How to test - create a new release (it has been used by many other projects) Signed-off-by: Rui Chen Co-authored-by: Michael Beemer --- .github/workflows/release-please.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/release-please.yaml b/.github/workflows/release-please.yaml index 6651f59b9..8a384fbdb 100644 --- a/.github/workflows/release-please.yaml +++ b/.github/workflows/release-please.yaml @@ -96,3 +96,18 @@ jobs: args: release --rm-dist env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + + homebrew: + name: Bump homebrew-core formula + runs-on: ubuntu-latest + if: ${{ needs.release-please.outputs.release_created }} + steps: + - uses: mislav/bump-homebrew-formula-action@v2 + with: + formula-name: flagd + commit-message: | + {{formulaName}} {{version}} + + Created by https://github.com/mislav/bump-homebrew-formula-action + env: + COMMITTER_TOKEN: ${{ secrets.COMMITTER_TOKEN }} From c653797f1c7291faff4918d8b3b24bee8481c94e Mon Sep 17 00:00:00 2001 From: Michael Beemer Date: Wed, 25 Jan 2023 12:55:32 -0500 Subject: [PATCH 4/7] ci: skip build action when only docs change (#320) Signed-off-by: Michael Beemer --- .github/workflows/build.yaml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index f21ec2bc1..fc8a5c2f1 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -2,12 +2,18 @@ name: build on: push: - branches: - - feature/workflows - - main + branches: + - feature/workflows + - main + paths-ignore: + - 'README.md' + - 'docs/**' pull_request: branches: - main + paths-ignore: + - 'README.md' + - 'docs/**' env: GO_VERSION: 1.19.3 From 8b9b94881a6808b1d3cce4d4cc57d3f49a2e596b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 25 Jan 2023 21:39:49 +0000 Subject: [PATCH 5/7] chore(deps): update docker/build-push-action digest to 37abced (#323) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://togithub.com/docker/build-push-action) | action | digest | `c56af95` -> `37abced` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- .github/workflows/build.yaml | 2 +- .github/workflows/release-please.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index fc8a5c2f1..5cb24c0f7 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -106,7 +106,7 @@ jobs: uses: docker/setup-buildx-action@master - name: Build - uses: docker/build-push-action@c56af957549030174b10d6867f20e78cfd7debc5 # v3 + uses: docker/build-push-action@37abcedcc1da61a57767b7588cb9d03eb57e28b3 # v3 with: context: . file: ./build.Dockerfile diff --git a/.github/workflows/release-please.yaml b/.github/workflows/release-please.yaml index 8a384fbdb..cf0dc59cc 100644 --- a/.github/workflows/release-please.yaml +++ b/.github/workflows/release-please.yaml @@ -59,7 +59,7 @@ jobs: id: date run: echo "::set-output name=date::$(date +'%Y-%m-%d')" - name: Build - uses: docker/build-push-action@c56af957549030174b10d6867f20e78cfd7debc5 # v3 + uses: docker/build-push-action@37abcedcc1da61a57767b7588cb9d03eb57e28b3 # v3 with: builder: ${{ steps.buildx.outputs.name }} context: . From ed1d3aaba4ca179a89757a6b1c3f328826e787fc Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 26 Jan 2023 01:31:44 +0000 Subject: [PATCH 6/7] fix(deps): update module github.com/open-feature/open-feature-operator to v0.2.25 (#324) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/open-feature/open-feature-operator](https://togithub.com/open-feature/open-feature-operator) | require | patch | `v0.2.24` -> `v0.2.25` | --- ### Release Notes
open-feature/open-feature-operator ### [`v0.2.25`](https://togithub.com/open-feature/open-feature-operator/releases/tag/v0.2.25) [Compare Source](https://togithub.com/open-feature/open-feature-operator/compare/v0.2.24...v0.2.25) ##### Features - Helm configuration ([#​304](https://togithub.com/open-feature/open-feature-operator/issues/304)) ([99edfeb](https://togithub.com/open-feature/open-feature-operator/commit/99edfeb8c32ada435f830c6799540ebdf3b5fcdd)) ##### Bug Fixes - removed duplicate config map generation, resolve permissions issue ([#​305](https://togithub.com/open-feature/open-feature-operator/issues/305)) ([eec16af](https://togithub.com/open-feature/open-feature-operator/commit/eec16af28eb963a3d0f276d382e808079e663a50)) - update x/net for CVE-2022-41721 ([#​301](https://togithub.com/open-feature/open-feature-operator/issues/301)) ([bbe9837](https://togithub.com/open-feature/open-feature-operator/commit/bbe983786ff74b59046b95082d79f71089fe2b67))
--- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 35d561745..ec05a7767 100644 --- a/go.mod +++ b/go.mod @@ -12,7 +12,7 @@ require ( github.com/fsnotify/fsnotify v1.6.0 github.com/golang/mock v1.6.0 github.com/mattn/go-colorable v0.1.13 - github.com/open-feature/open-feature-operator v0.2.24 + github.com/open-feature/open-feature-operator v0.2.25 github.com/open-feature/schemas v0.2.8 github.com/prometheus/client_golang v1.14.0 github.com/robfig/cron v1.2.0 diff --git a/go.sum b/go.sum index 6f2214111..f916d0d12 100644 --- a/go.sum +++ b/go.sum @@ -281,6 +281,8 @@ github.com/onsi/ginkgo/v2 v2.6.0 h1:9t9b9vRUbFq3C4qKFCGkVuq/fIHji802N1nrtkh1mNc= github.com/onsi/gomega v1.24.1 h1:KORJXNNTzJXzu4ScJWssJfJMnJ+2QJqhoQSRwNlze9E= github.com/open-feature/open-feature-operator v0.2.24 h1:6UwfHO7pa2WDDpdyL+hzYwukbooAA2IZFgyj5xga2vw= github.com/open-feature/open-feature-operator v0.2.24/go.mod h1:6zsu3m2sa8b4qJlHIAp1Kuc80mCAOAkBCkvDTTyv9ZY= +github.com/open-feature/open-feature-operator v0.2.25 h1:6X1dn7YTTCxRj7Sq6NR3ThDvXYt+4VPPC1GP7D5GD+Q= +github.com/open-feature/open-feature-operator v0.2.25/go.mod h1:8OFtVXXdVpZTSx1vHravbTYup4iyeb+PLmiKbRL11TA= github.com/open-feature/schemas v0.2.8 h1:oA75hJXpOd9SFgmNI2IAxWZkwzQPUDm7Jyyh3q489wM= github.com/open-feature/schemas v0.2.8/go.mod h1:vj+rfTsOLlh5PtGGkAbitnJmFPYuTHXTjOy13kzNgKQ= github.com/pelletier/go-toml/v2 v2.0.6 h1:nrzqCb7j9cDFj2coyLNLaZuJTLjWjlaz6nvTvIwycIU= From 8013ea5c6fa311b337c7ec1b1e8e756080808948 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 26 Jan 2023 04:50:04 +0000 Subject: [PATCH 7/7] fix(deps): update module google.golang.org/grpc to v1.52.3 (#325) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [google.golang.org/grpc](https://togithub.com/grpc/grpc-go) | require | patch | `v1.52.1` -> `v1.52.3` | --- ### Release Notes
grpc/grpc-go ### [`v1.52.3`](https://togithub.com/grpc/grpc-go/releases/tag/v1.52.3): Release 1.52.3 [Compare Source](https://togithub.com/grpc/grpc-go/compare/v1.52.1...v1.52.3) ### Bug Fixes - Fix user-agent version
--- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index ec05a7767..972d2d721 100644 --- a/go.mod +++ b/go.mod @@ -26,7 +26,7 @@ require ( go.uber.org/zap v1.24.0 golang.org/x/net v0.5.0 golang.org/x/sync v0.1.0 - google.golang.org/grpc v1.52.1 + google.golang.org/grpc v1.52.3 google.golang.org/protobuf v1.28.1 gopkg.in/yaml.v3 v3.0.1 k8s.io/api v0.26.1 diff --git a/go.sum b/go.sum index f916d0d12..17ce3ad4c 100644 --- a/go.sum +++ b/go.sum @@ -717,6 +717,8 @@ google.golang.org/grpc v1.52.0 h1:kd48UiU7EHsV4rnLyOJRuP/Il/UHE7gdDAQ+SZI7nZk= google.golang.org/grpc v1.52.0/go.mod h1:pu6fVzoFb+NBYNAvQL08ic+lvB2IojljRYuun5vorUY= google.golang.org/grpc v1.52.1 h1:2NpOPk5g5Xtb0qebIEs7hNIa++PdtZLo2AQUpc1YnSU= google.golang.org/grpc v1.52.1/go.mod h1:pu6fVzoFb+NBYNAvQL08ic+lvB2IojljRYuun5vorUY= +google.golang.org/grpc v1.52.3 h1:pf7sOysg4LdgBqduXveGKrcEwbStiK2rtfghdzlUYDQ= +google.golang.org/grpc v1.52.3/go.mod h1:pu6fVzoFb+NBYNAvQL08ic+lvB2IojljRYuun5vorUY= google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8= google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0= google.golang.org/protobuf v0.0.0-20200228230310-ab0ca4ff8a60/go.mod h1:cfTl7dwQJ+fmap5saPgwCLgHXTUD7jkjRqWcaiX5VyM=