Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkout release tag before running container and binary releases #171

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

beeme1mr
Copy link
Member

Checks out the release tag before running the container and binary release steps. This ensures that Go Releaser is able to detect the version number properly and upload the artifacts.

I've tested this in a branch. You can see the results GitHub Release. I've also verified that both the container and binaries return the expected version numbers when running flagd version.

Signed-off-by: Michael Beemer beeme1mr@users.noreply.github.com

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@toddbaert toddbaert self-requested a review September 23, 2022 21:08
@beeme1mr beeme1mr merged commit 50fe46f into main Sep 23, 2022
@beeme1mr beeme1mr deleted the fix/release-please-artifact-upload branch September 23, 2022 21:10
AlexsJones pushed a commit that referenced this pull request Sep 26, 2022
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](v0.1.1...v0.2.0)
(2022-09-26)


### ⚠ BREAKING CHANGES

* Updated service to use connect (#163)

### Features

* Updated service to use connect
([#163](#163))
([828d5c4](828d5c4))


### Bug Fixes

* checkout release tag before running container and binary releases
([#171](#171))
([50fe46f](50fe46f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants