-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Eventing #187
feat: Eventing #187
Conversation
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
@AlexsJones just for some background, one of the coolest parts of this is it allows providers to cache resolved flag values (based on a sha of the |
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
It's a good move, I think the interfaces are getting a bit bruised though - suggesting we encapsulate with a configuration object. |
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: James-Milligan <james@omnant.co.uk>
🤖 I have created a release *beep* *boop* --- ## [0.2.3](v0.2.2...v0.2.3) (2022-10-13) ### Features * Eventing ([#187](#187)) ([3f7fcd2](3f7fcd2)) * fixing informer issues ([#191](#191)) ([837b0c6](837b0c6)) * only fire modify event when FeatureFlagConfiguration Generation field has changed ([#167](#167)) ([e2fc7ee](e2fc7ee)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR
This PR adds a new rpc to the connect service called EventStream, it accepts an empty proto message google.proto.Empty and returns a stream of message type EventStreamResponse.
EventStreamResponse contains a single string field of type which references an internal notification type used within flagd, such as provider_ready or configuration_change. This rpc will allow for the management of the sdk cache, busting it once a configuration change is detected. It will also allow for the implementation of flag change events once/if the OFEP passes.