feat: fixing informer issues #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
beeme1mr
requested review from
skyerus,
toddbaert,
thomaspoignant,
thschue and
james-milligan
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
skyerus
reviewed
Oct 13, 2022
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
skyerus
reviewed
Oct 13, 2022
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
james-milligan
approved these changes
Oct 13, 2022
skyerus
approved these changes
Oct 13, 2022
AlexsJones
pushed a commit
that referenced
this pull request
Oct 13, 2022
🤖 I have created a release *beep* *boop* --- ## [0.2.3](v0.2.2...v0.2.3) (2022-10-13) ### Features * Eventing ([#187](#187)) ([3f7fcd2](3f7fcd2)) * fixing informer issues ([#191](#191)) ([837b0c6](837b0c6)) * only fire modify event when FeatureFlagConfiguration Generation field has changed ([#167](#167)) ([e2fc7ee](e2fc7ee)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely reimplements the informer system.
It now avoids the issues using the cache informer watcher which occasionally ommits errors - to my best reckoning it is due to partial object updates not deserialising properly.