fix: fix race in http sync test #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
requested review from
AlexsJones,
james-milligan and
Kavindu-Dodan
as code owners
toddbaert
force-pushed
the
fix/http-sync-test-race
branch
from
82c7b6a to
3cf1538
Compare
Codecov Report
@@ Coverage Diff @@
## main #401 +/- ##
==========================================
+ Coverage 65.62% 65.65% +0.02%
==========================================
Files 10 10
Lines 1213 1214 +1
==========================================
+ Hits 796 797 +1
Misses 367 367
Partials 50 50
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
toddbaert
force-pushed
the
fix/http-sync-test-race
branch
from
3cf1538 to
b780c7b
Compare
toddbaert
force-pushed
the
fix/http-sync-test-race
branch
from
b780c7b to
f5ee476
Compare
toddbaert
commented
Feb 10, 2023
Kavindu-Dodan
approved these changes
Feb 10, 2023
james-milligan
approved these changes
Feb 13, 2023
skyerus
approved these changes
Feb 13, 2023
Signed-off-by: Todd Baert <toddbaert@gmail.com>
toddbaert
force-pushed
the
fix/http-sync-test-race
branch
from
f5ee476 to
c07027b
Compare
Kavindu-Dodan
pushed a commit
that referenced
this pull request
Feb 13, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.7](v0.3.6...v0.3.7) (2023-02-13) ### Bug Fixes * **deps:** update module golang.org/x/net to v0.6.0 ([#396](#396)) ([beb7564](beb7564)) * **deps:** update module google.golang.org/grpc to v1.53.0 ([#388](#388)) ([174cd7c](174cd7c)) * error handling of Serve/ServeTLS funcs ([#397](#397)) ([8923bf2](8923bf2)) * fix race in http sync test ([#401](#401)) ([1d0c8e1](1d0c8e1)) * sbom artefact name ([#380](#380)) ([3daef26](3daef26)), closes [#379](#379) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
TestSimpleSynctest we are asserting thaths.Cron.AddFuncandhs.Cron.Startare called by the time thedataSyncis sent. This is a race, because these methods are actually called after the first send. I get failures here ~25% of the time (seems like @skyerus does too).This changes things to add the handler and start the cron before the first send, which makes things deterministic.