Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Changes in observed FeatureFlagConfigs are not propagated to the EventStream with v0.5.0 #603

Closed
bacherfl opened this issue Apr 12, 2023 · 1 comment · Fixed by #605
Assignees
Labels
bug Something isn't working

Comments

@bacherfl
Copy link
Contributor

Observed behavior

When using v0.5.0 of Flagd in a FlagSourceConfiguration - see https://github.com/open-feature/cloud-native-demo/blob/main/deployment/flagd-flag-spec.yaml - changes in the referenced FeatureFlagConfigurations do not cause a configuration_change event to be sent to the EventStream. provider_ready and keep_alive events are received by the client.
When setting the flagd version to 0.4.4, changes to a FeatureFlagConfiguration are propagated to the EventStream as expected.

Expected Behavior

When updating a FeatureFlagConfigurationcustom resource referenced in the --uri argument, this should result in a configuration_change event to be sent to the subscribed clients.

Steps to reproduce

  1. Run flagd with a kubernetes sync source, e.g.:
flagd start --uri=core.openfeature.dev/open-feature-demo/client-side
  1. Subscribe to the eventStream with a grpc client
  2. Change the observed FeatureFlagConfiguration client-side
  3. Observe the EventStream - provider_ready and keep_alive events are received, but no configuration_change events are sent by flagd
@bacherfl bacherfl added bug Something isn't working Needs Triage This issue needs to be investigated by a maintainer labels Apr 12, 2023
@Kavindu-Dodan Kavindu-Dodan self-assigned this Apr 12, 2023
@Kavindu-Dodan
Copy link
Contributor

The root cause is a misconfiguration

flag evaluator contains a dedicated eventingConfiguration [1] which is not reflected at connect_service [2]

[1] - https://github.com/open-feature/flagd/blob/main/core/pkg/service/flag-evaluation/flag_evaluator.go#L40-L42
[2] -https://github.com/open-feature/flagd/blob/main/core/pkg/service/flag-evaluation/connect_service.go#L46-L48

@beeme1mr beeme1mr removed the Needs Triage This issue needs to be investigated by a maintainer label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants