Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new flagd-evaluator e2e suite #898

Merged
merged 9 commits into from
Sep 13, 2023
Merged

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Sep 8, 2023

Uses test suite defined here to validate json evaluator behavior end-to-end, by using the test suite added here.

@toddbaert toddbaert requested a review from a team as a code owner September 8, 2023 16:35
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit b90c3d7
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/6501e903dc63190008c604fd

@toddbaert toddbaert marked this pull request as draft September 8, 2023 16:39
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #898 (b90c3d7) into main (84fcea6) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #898   +/-   ##
=======================================
  Coverage   72.73%   72.73%           
=======================================
  Files          28       28           
  Lines        2857     2857           
=======================================
  Hits         2078     2078           
  Misses        683      683           
  Partials       96       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert force-pushed the chore/json-eval-tests branch 2 times, most recently from ace59d5 to 18a5858 Compare September 11, 2023 14:22
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
.gitmodules Show resolved Hide resolved
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert changed the title chore: add new flagd-evaluator e2e suite (WIP) chore: add new flagd-evaluator e2e suite Sep 11, 2023
@toddbaert toddbaert marked this pull request as ready for review September 11, 2023 17:56
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor remark but otherwise looks good

see - https://github.com/open-feature/flagd/pull/898/files#r1322139914

@toddbaert toddbaert merged commit 37ab55d into main Sep 13, 2023
16 checks passed
@toddbaert toddbaert deleted the chore/json-eval-tests branch September 13, 2023 17:35
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Kavindu-Dodan pushed a commit that referenced this pull request Sep 14, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.6.6</summary>

##
[0.6.6](flagd/v0.6.5...flagd/v0.6.6)
(2023-09-14)


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.6.5
([#900](#900))
([c2ddcbf](c2ddcbf))


### 🧹 Chore

* add new flagd-evaluator e2e suite
([#898](#898))
([37ab55d](37ab55d))
</details>

<details><summary>flagd-proxy: 0.2.11</summary>

##
[0.2.11](flagd-proxy/v0.2.10...flagd-proxy/v0.2.11)
(2023-09-14)


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.6.5
([#900](#900))
([c2ddcbf](c2ddcbf))
</details>

<details><summary>core: 0.6.6</summary>

##
[0.6.6](core/v0.6.5...core/v0.6.6)
(2023-09-14)


### 🐛 Bug Fixes

* **deps:** update kubernetes packages to v0.28.2
([#911](#911))
([2eda6ab](2eda6ab))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.16.2
([#907](#907))
([9976851](9976851))
* **deps:** update opentelemetry-go monorepo
([#906](#906))
([5a41226](5a41226))
* use 32bit murmur calculation (64 is not stable)
([#913](#913))
([db8dca4](db8dca4))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants