-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use 32bit murmur calculation (64 is not stable) #913
fix: use 32bit murmur calculation (64 is not stable) #913
Conversation
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Codecov Report
@@ Coverage Diff @@
## main #913 +/- ##
==========================================
- Coverage 72.73% 72.71% -0.02%
==========================================
Files 28 28
Lines 2857 2855 -2
==========================================
- Hits 2078 2076 -2
Misses 683 683
Partials 96 96
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kavindu-Dodan !
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
FYI @craigpastro , this is a small change, but many languages don't support a 64 bit murmur3. It's not in the murmur3 spec, so we're using 32 now which seems to be consistently implemented. cc @beeme1mr |
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.6.6</summary> ## [0.6.6](flagd/v0.6.5...flagd/v0.6.6) (2023-09-14) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.6.5 ([#900](#900)) ([c2ddcbf](c2ddcbf)) ### 🧹 Chore * add new flagd-evaluator e2e suite ([#898](#898)) ([37ab55d](37ab55d)) </details> <details><summary>flagd-proxy: 0.2.11</summary> ## [0.2.11](flagd-proxy/v0.2.10...flagd-proxy/v0.2.11) (2023-09-14) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.6.5 ([#900](#900)) ([c2ddcbf](c2ddcbf)) </details> <details><summary>core: 0.6.6</summary> ## [0.6.6](core/v0.6.5...core/v0.6.6) (2023-09-14) ### 🐛 Bug Fixes * **deps:** update kubernetes packages to v0.28.2 ([#911](#911)) ([2eda6ab](2eda6ab)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.16.2 ([#907](#907)) ([9976851](9976851)) * **deps:** update opentelemetry-go monorepo ([#906](#906)) ([5a41226](5a41226)) * use 32bit murmur calculation (64 is not stable) ([#913](#913)) ([db8dca4](db8dca4)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR
Fixes murmur3 hash calculation to be cross language compatible.
See PR discussion here for more details - open-feature/java-sdk-contrib#434
Depends on flagd-testbed PR - open-feature/flagd-testbed#65