Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gofeatureflag): Add support of flag change cache removal #821

Merged
merged 5 commits into from
Jun 19, 2024
Merged

feat(gofeatureflag): Add support of flag change cache removal #821

merged 5 commits into from
Jun 19, 2024

Conversation

thomaspoignant
Copy link
Member

This PR

  • Refactor of GO Feature Flag provider to have better separation of concerns in the provider.
  • Add support for polling the new endpoint to detect flag changes.

@thomaspoignant
feat(gofeatureflag): Add support of flag change cache removal
6d20683 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant force-pushed the feat-add-polling-config-change branch 2 times, most recently from 1867697 to 64964c5 Compare June 11, 2024 19:02
@thomaspoignant
add unit test for flag cache invalidation
354d700 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant marked this pull request as ready for review June 11, 2024 19:08
@thomaspoignant thomaspoignant requested a review from a team as a code owner June 11, 2024 19:08
liran2000
liran2000 reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@liran2000 liran2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, added some comments.

...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java Show resolved Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java Outdated Show resolved Hide resolved
...rc/main/java/dev/openfeature/contrib/providers/gofeatureflag/controller/CacheController.java Show resolved Hide resolved
.../main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProviderOptions.java Show resolved Hide resolved
@thomaspoignant thomaspoignant mentioned this pull request Jun 12, 2024
Open
@thomaspoignant
fix: review comment
3e71bd9 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant mentioned this pull request Jun 13, 2024
Merged
3 tasks
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Closed
@thomaspoignant
Copy link
Member Author

I am merging even if there is a CI error because this is caused by an issue in flagd tests.

@thomaspoignant thomaspoignant merged commit 536de91 into main Jun 19, 2024
3 of 4 checks passed
@thomaspoignant thomaspoignant deleted the feat-add-polling-config-change branch June 19, 2024 09:15
@github-actions github-actions bot mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbaert toddbaert toddbaert approved these changes

@liran2000 liran2000 liran2000 approved these changes

Assignees

@thomaspoignant thomaspoignant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaspoignant @toddbaert @liran2000