Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint issues and bump server sdk version #715

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Jan 2, 2024

This PR

  • fix linting issues across the repo
  • bumped server sdk version

Notes

These issues were showing up in the "Unchanged files with check annotations" section of other PRs.

@beeme1mr beeme1mr requested a review from a team as a code owner January 2, 2024 18:06
@beeme1mr beeme1mr changed the title chore: fix flagd lint issues chore: fix lint issues and bump server sdk version Jan 3, 2024
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but there's a couple more lint issues you can fix if you want. Some might be easy to fix, for those that are not I would suggest you ignore them.

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
Copy link
Member Author

beeme1mr commented Jan 3, 2024

@toddbaert fixed.

@beeme1mr beeme1mr deleted the fix-lint-issues branch January 4, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants