-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: builds helm chart #137
Conversation
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 122 122
=====================================
Misses 122 122 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
That gets me I think you mean However, the |
Fixed, this was due to missing CRD's and wrong image |
7bc3fba
to
e980211
Compare
6ed73ea
to
8eec39c
Compare
I'll test this again in a couple hours when I'm back at my PC! |
Thanks! This all works for me provided I install cert-manager first, otherwise I'm missing objects.
I'm know this is a pre-requisite, and not a new one, but I'm still a bit confused if this hard dependency is a good idea. Could the cert manager requirement prevent adoption if an admin has some alternative policy or solution for generating self-signed certs? Is it more or less standard for operators that accept requests to require cert-manager? I'm not truly not sure, so I defer once more to your expertise, @AlexsJones ! |
@AlexsJones I pushed a commit to add a couple files to the release please |
For posterity, the reason it needs the certificate is for mTLS between the api-server and the webhook. |
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Switching to use release-please comment Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: Alex Jones <alex.jones@canonical.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
04d53a2
to
12442c3
Compare
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Please review when you have a spare moment, I added to the readme @toddbaert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readme changes look good to me!
Sorry for that missing comma!
This PR is in two parts
First part This PR is to implement the helm chart and simplify the generation of that chart
The second part will be to serve the chart from the repo
After this is accepted I will add the code to convert this repo into a helm repo which will enable
for now you can use