Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Helm configuration #304

Merged
merged 43 commits into from
Jan 25, 2023
Merged

feat: Helm configuration #304

merged 43 commits into from
Jan 25, 2023

Conversation

james-milligan
Copy link
Contributor

@james-milligan james-milligan commented Jan 18, 2023

This PR

  • ensured all values in values.yaml are reflected in the deployed chart
  • adds additional sidecar configuration options via values.yaml

Related Issues

#271

Notes

Follow-up Tasks

How to test

update values in values.yaml, or via the command line, and run helm upgrade -i open-feature-operator ./chart/open-feature-operator --dry-run > dry-run.yaml all replaced directives should be filled in the dry run.

Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Merging #304 (308c097) into main (75bdd8b) will increase coverage by 0.94%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   54.04%   54.99%   +0.94%     
==========================================
  Files           4        4              
  Lines         507      511       +4     
==========================================
+ Hits          274      281       +7     
+ Misses        212      209       -3     
  Partials       21       21              
Impacted Files Coverage Δ
webhooks/pod_webhook.go 67.68% <20.00%> (+1.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: James Milligan <james@omnant.co.uk>
apis/core/v1alpha1/flagsourceconfiguration_types.go Outdated Show resolved Hide resolved
chart/open-feature-operator/README.md Outdated Show resolved Hide resolved
webhooks/pod_webhook.go Outdated Show resolved Hide resolved
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan james-milligan changed the title feat: Helm configuration feat!: Helm configuration Jan 18, 2023
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
@toddbaert
Copy link
Member

@james-milligan whenever you feel this is ready, just let me know and I'll do a test in my environment as a sanity check.

@james-milligan
Copy link
Contributor Author

@james-milligan whenever you feel this is ready, just let me know and I'll do a test in my environment as a sanity check.

should be good to go!

@james-milligan james-milligan marked this pull request as ready for review January 18, 2023 20:17
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan james-milligan marked this pull request as draft January 19, 2023 11:38
@james-milligan james-milligan marked this pull request as ready for review January 19, 2023 11:45
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
@toddbaert
Copy link
Member

toddbaert commented Jan 19, 2023

│ flag provided but not defined: -sidecar-cpu-limit                                                                                                                         │
│ Usage of /manager:                

I get that in the operator pod on startup after running helm install ofo . from the charts dir

I think this is my fault, I didn't pass the arg for my locally built image.

@toddbaert toddbaert self-requested a review January 19, 2023 18:31
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected! Thanks!

james-milligan and others added 4 commits January 20, 2023 09:32
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
apis/core/v1alpha1/flagsourceconfiguration_types.go Outdated Show resolved Hide resolved
apis/core/v1alpha1/flagsourceconfiguration_types.go Outdated Show resolved Hide resolved
chart/open-feature-operator/README.md Outdated Show resolved Hide resolved
chart/open-feature-operator/README.md Outdated Show resolved Hide resolved
chart/open-feature-operator/README.md Outdated Show resolved Hide resolved
chart/open-feature-operator/README.md Outdated Show resolved Hide resolved
chart/open-feature-operator/README.md Outdated Show resolved Hide resolved
chart/open-feature-operator/values.yaml Outdated Show resolved Hide resolved
james-milligan and others added 3 commits January 24, 2023 15:11
Co-authored-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
Signed-off-by: James Milligan <james@omnant.co.uk>
@beeme1mr beeme1mr self-requested a review January 24, 2023 19:23
@james-milligan james-milligan merged commit 99edfeb into open-feature:main Jan 25, 2023
@james-milligan james-milligan deleted the helm-config-changes branch January 25, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants