Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uniqueness of featureflagconfiguration file path #323

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

skyerus
Copy link
Contributor

@skyerus skyerus commented Jan 27, 2023

Signed-off-by: Skye Gill gill.skye95@gmail.com

This PR

  • Enforces uniqueness of featureflagconfiguration file path across namespaces.

Related Issues

Notes

Follow-up Tasks

How to test

Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #323 (fea742b) into main (2ec454c) will increase coverage by 2.30%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   60.84%   63.14%   +2.30%     
==========================================
  Files           4        4              
  Lines         521      521              
==========================================
+ Hits          317      329      +12     
+ Misses        184      174      -10     
+ Partials       20       18       -2     
Impacted Files Coverage Δ
controllers/featureflagconfiguration_controller.go 0.00% <0.00%> (ø)
webhooks/pod_webhook.go 78.86% <100.00%> (+3.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert
Copy link
Member

Sorry for only pointing this out after that last PR was merged! 😅

@beeme1mr beeme1mr merged commit 2b10945 into open-feature:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants