Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes event handling exhibits inconsistent behaviour when multiple sync providers are configured #324

Closed
skyerus opened this issue Jan 27, 2023 · 1 comment · Fixed by #325
Labels
bug Something isn't working

Comments

@skyerus
Copy link
Contributor

skyerus commented Jan 27, 2023

While expanding the e2e test suite to cover #319 I discovered that configuring multiple sync providers causes unexpected behaviour in the kubernetes event listener. flagd's internal state is not being updated to reflect a change in the FeatureFlagConfiguration.
To reproduce this:

  1. Check out the branch in my PR.
  2. Deploy the operator.
  3. Run kubectl -n open-feature-operator-system apply -f ./test/e2e/e2e.yml
  4. Expose the service kubectl -n open-feature-operator-system port-forward service/open-feature-e2e-test-service 30000:30000
  5. Run the test (passes/fails intermittently) ./test/e2e/tests/002.crd-configuration-reconciliation.sh

Tailing flagd's logs I can see that the event is received, the problem lies somewhere within https://github.com/open-feature/flagd/blob/main/pkg/sync/kubernetes/kubernetes_sync.go#L225

@skyerus skyerus added the bug Something isn't working label Jan 27, 2023
@skyerus skyerus changed the title Kubernetes event listening exhibits inconsistent behaviour when multiple sync providers are configured Kubernetes event handling exhibits inconsistent behaviour when multiple sync providers are configured Jan 27, 2023
@toddbaert
Copy link
Member

I think this was resolved with both these PRs:

#326

open-feature/flagd#339

(but we still need #325 for tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants