feat: add log format configuration options through helm chart

[mowies]

This PR

• adds a new sidecarConfiguration.logFormat helm value that is handed over to the operator as an env var
• sets the default sidecar log format to json both in code and in the CRD itself, as well as the helm chart

Fixes #334

[james-milligan]

The Merge method in apis/core/v1alpha1/flagsourceconfiguration_types.go should be extended to ensure this configuration isn't dropped.

if new.DefaultLogFormat != "" {
	fc.DefaultLogFormat = new.DefaultLogFormat
}

I may also be worthwhile adding this configuration to one of the existing tests in /webhooks/pod_webhook_test.go as this will catch the above issue in future PRs

[mowies]

@james-milligan thanks for the review!
I fixed your remarks, adjusted the mutating webhook tests, and also re-generated the helm chart (not sure if that's needed or not)
pls re-review :)

[mowies]

the failing test works for me locally... can somebody maybe start a re-run?

[skyerus]

the failing test work for me locally... can somebody maybe start a re-run?

Done! Note: there's an issue for this flakey test #347

[codecov]

Codecov Report

Merging #346 (99dadd9) into main (56ea082) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files           4        4           
  Lines         532      532           
=======================================
  Hits          327      327           
  Misses        185      185           
  Partials       20       20           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[toddbaert]

I didn't manually test this one but it looks good to me; tests are passing now and it looks like @james-milligan 's concerns (including the conversion) have been resolved.

[skyerus]

LGTM, thanks :)