Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Security issues #348

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com

Fixes #311

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #348 (b0b62c7) into main (a0993dc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files           4        4           
  Lines         532      532           
=======================================
  Hits          327      327           
  Misses        185      185           
  Partials       20       20           
Impacted Files Coverage Δ
webhooks/pod_webhook.go 76.05% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@beeme1mr
Copy link
Member

Thanks @odubajDT, as a follow up, could you please update the docs that cover permissions? This should be handled in a separate PR so we can release it when this change is available.

@odubajDT
Copy link
Contributor Author

Thanks @odubajDT, as a follow up, could you please update the docs that cover permissions? This should be handled in a separate PR so we can release it when this change is available.

Thanks! Created a PR: #350

@toddbaert toddbaert self-requested a review February 15, 2023 16:43
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and if there was anything substantial missed, our e2e tests would catch them. Thanks!

odubajDT and others added 2 commits February 16, 2023 15:01
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert toddbaert merged commit 5bd0b19 into open-feature:main Feb 16, 2023
@odubajDT odubajDT deleted the fix/311/security branch March 14, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate security findings
3 participants