chore: remove unneeded conversion webhooks + introduce unit tests for conversion functions #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conversion functions Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Codecov Report
@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 63.91% 70.51% +6.60%
==========================================
Files 5 11 +6
Lines 629 814 +185
==========================================
+ Hits 402 574 +172
- Misses 201 213 +12
- Partials 26 27 +1
... and 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
odubajDT
force-pushed
the
refactoring/webhooks
branch
from
555edf2
to
83f5cbb
Compare
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT
force-pushed
the
refactoring/webhooks
branch
2 times, most recently
from
72a8ad6
to
403f7ec
Compare
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT
force-pushed
the
refactoring/webhooks
branch
from
2104f29
to
361ece2
Compare
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
skyerus
reviewed
Mar 14, 2023
skyerus
reviewed
Mar 14, 2023
odubajDT
force-pushed
the
refactoring/webhooks
branch
from
1b2ca3d
to
7a2c742
Compare
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Kavindu-Dodan
approved these changes
Mar 15, 2023
skyerus
reviewed
Mar 16, 2023
Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
skyerus
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Part of #370