-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable flagd probes #390
feat: enable flagd probes #390
Conversation
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
d542e5a
to
f6cb293
Compare
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage ? 71.29%
=======================================
Files ? 11
Lines ? 836
Branches ? 0
=======================================
Hits ? 596
Misses ? 213
Partials ? 27
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hey @Kavindu-Dodan, could you please update the Artifact Hub readme with the new information? |
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Thanks, I updated (along with formatting improvement) the readme. Also, your review helped to validate Helm configurations which I missed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a feature and documentation perspective. Nice job with the PR description by the way!
This PR
Relates to #408
Introduce flagd Liveness and Readiness probes for side-car deployed through OFO. Default is
enabled
(probes are enabled).Behavior can be controlled through
FlagSourceConfiguration
CRD fieldprobesEnabled
.probesEnabled
:true
,false
How to test
Consider the following FlagSourceConfiguration CRD configurations,
Probes enabled (default),
Probes disabled,
Alternatively, it is possible to configure the behavior from OFO Helm deployment. For this, helm value
sidecarConfiguration.probesEnabled
can be used. This internally maps to OFO manager env varSIDECAR_PROBES_ENABLED
.Helm value based overriding is desired if probes need to be disabled by default and be enabled by overriding through
FlagSourceConfiguration
CRD definition.